MCP, MCP server
Keenetic Mcp
MCP (Model Context Protocol) server for Keenetic routers.
Compatibility: Not stated.
Grade B
Minor issues only, no Medium or High. Worth a quick look at the findings below before installing.
Not a guarantee. A hygiene check of the source at the commit shown, not a security audit.
PERMISSION_DELETE_FILES NETWORK_NO_FIXED_HOST SECRETS_PATH_DOTENV SECRETS_ENV_READ
Why this grade
- PERMISSION_DELETE_FILES Low
Contains a call that can delete files.
backup.py, line 17
subprocess.run(["logger", "-t", "keenetic-mcp", message], - NETWORK_NO_FIXED_HOST Low
Makes a network call whose host is not written as a fixed address.
backup.py, line 64
resp = urllib.request.urlopen(req, timeout=15) - SECRETS_PATH_DOTENV Low
Mentions a .env file.
backup.py, line 111
# Three files that no `git pull` can bring back: .env and watch_rules.json are - SECRETS_ENV_READ Note
Reads an environment variable whose name contains KEY, SECRET, TOKEN, PASSWORD or CREDENTIAL.
core.py, line 104
SECRET = os.environ.get("MCP_SECRET", SECRET)
Any High, or two or more Medium findings, give D. One Medium gives C. Low findings or a security Note give B. Each code names a finding behind the letter.
Grades are a hygiene check of the source at the commit shown, on the date checked, not a security audit or a guarantee. The free directory grades are automated. Before release, a PlugVet engineer reviews every paid report and any grade we hold back, including all F grades, against the source code and the evidence we quote.
What was checked
Plain notes from the hygiene checks.
Permissions
Concern
can delete files.
PERMISSION_DELETE_FILES
backup.py, line 17
subprocess.run(["logger", "-t", "keenetic-mcp", message],
backup.py, line 90
return subprocess.run(["which", "rsync"], capture_output=True).returncode == 0
backup.py, line 99
result = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
Show more
backup.py, line 177
shutil.rmtree(stage_dir)
backup.py, line 220
r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
backup.py, line 237
r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
backup.py, line 247
shutil.rmtree(local_dir)
backup.py, line 251
r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
backup.py, line 262
r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
backup.py, line 278
shutil.rmtree(p)
backup.py, line 280
os.remove(p)
backup.py, line 349
shutil.rmtree(snap_stage)
backup.py, line 423
os.remove(tmp_path)
backup.py, line 448
os.remove(os.path.join(core.BACKUP_PATH, old))
tools_system.py, line 37
r = subprocess.run(
tools_system.py, line 335
os.remove(tmp_path)
Install and update
Pass
No install-time script found, and dependencies are pinned or absent.
Network
Concern
can reach a host that is not written as a fixed address.
NETWORK_NO_FIXED_HOST
backup.py, line 64
resp = urllib.request.urlopen(req, timeout=15)
core.py, line 164
urllib.request.urlopen(req)
core.py, line 180
resp = urllib.request.urlopen(req2)
Show more
core.py, line 206
return urllib.request.urlopen(req, timeout=timeout)
core.py, line 224
urllib.request.urlopen(req)
core.py, line 239
resp = urllib.request.urlopen(req2)
core.py, line 257
resp = urllib.request.urlopen(req, timeout=timeout)
core.py, line 279
return urllib.request.urlopen(req, timeout=timeout)
Secrets
Concern
reads a credential or environment file.
SECRETS_ENV_READ SECRETS_PATH_DOTENV
backup.py, line 111
# Three files that no `git pull` can bring back: .env and watch_rules.json are
backup.py, line 161
candidates = [os.path.join(base, ".env"), rules, core.BACKUP_MCP_INIT]
core.py, line 104
SECRET = os.environ.get("MCP_SECRET", SECRET)
Show more
backup.py, line 301
result["error"] = "disabled (BACKUP_MCP_CONFIG=false in .env)"
backup.py, line 304
result["error"] = "rsync target not configured (BACKUP_RSYNC_* in .env)"
core.py, line 26
# .env and watch_rules.json (both gitignored) and the hand-edited Entware init
core.py, line 92
env_file = os.path.join(os.path.dirname(__file__), ".env")
core.py, line 113
BACKUP_RSYNC_KEY = os.environ.get("BACKUP_RSYNC_KEY", "")
http_tools.py, line 61
"MCP_HTTP_TOOL_ALLOWLIST in .env if you really want this"
registry.py, line 306
"Back up the keenetic-mcp files that git cannot restore (.env, "
Agent instructions
Pass
No instruction to ignore earlier instructions or to hide a step.
Obfuscation
Pass
No encoded or minified payload found.
Licence
Pass
A licence file is present (LICENSE).
Maintainer activity
Pass
The latest commit is within the last 365 days.
Note
Hygiene check of commit 80ed1133a769. can delete files. can reach a host that is not written as a fixed address. reads a credential or environment file.
Date and source
Date checked:
github.com
Commit graded: 80ed1133a76901cf6dab797198bb70aed3d387df
This link goes to the original host. PlugVet does not host or check what you download from there, and installing it is your own decision and risk.